Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%Rpush: Look for variables in the local scope first. #2731

Merged
merged 2 commits into from Jan 2, 2013

Conversation

bfroehle
Copy link
Contributor

@bfroehle bfroehle commented Jan 2, 2013

This is intended as a cleaned up version of #2698 & #2552, which partially addresses the issue in #2550.

The issue had two components:

  1. The %Rpush line magic did not look for variables in the local scope.
  2. The %Rpush line magic expected variable names to be separated with spaces.

This pull request addresses only the first of these two issues. I feel that the issues are sufficiently different to deserve separate consideration (and separate pull requests). In particular, %Rpull currently requires variable names to be separated by spaces as well and I think we should ensure that the semantics for %Rpush and %Rpull remain identical.

I'm going to close #2698 and link to this issue.

@bfroehle
Copy link
Contributor Author

bfroehle commented Jan 2, 2013

Test results for commit 5e268bb merged into master (ca39815)
Platform: linux2

  • python2.7: OK (libraries not available: azure)
  • python3.2: OK (libraries not available: azure jinja2 oct2py pymongo rpy2 wx wx.aui)

Not available for testing: python2.6

@takluyver
Copy link
Member

Looks good to me.

bfroehle added a commit that referenced this pull request Jan 2, 2013
%Rpush: Look for variables in the local scope first.
@bfroehle bfroehle merged commit 399d860 into ipython:master Jan 2, 2013
mattvonrocketstein pushed a commit to mattvonrocketstein/ipython that referenced this pull request Nov 3, 2014
%Rpush: Look for variables in the local scope first.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants